apmmachine
commented
4 years ago :green_heart: Build Succeeded
Expand to view the summary
#### Build stats * Build Cause: `[Pull request #185 opened]` * Start Time: 2020-07-30T07:31:04.282+0000 * Duration: 3 min 9 sec #### Test stats :test_tube: | Test | Results | | ------------ | :-----------------------------: | | Failed | 0 | | Passed | 9 | | Skipped | 0 | | Total | 9 |
types.M and types.Is are replaced by spelling out their underlying types. Marginally more verbose, but removes a package.
conv.ToMap is replaced by explicitly encoding to JSON and then decoding, with proper error handling. Only used in two places, does not warrant a separate package/utility.
conv.ByteCountDecimal replaced by dustin/go-humanize's Bytes function. Fixed (removed) invalid MemStats.HeapAlloc delta metric; HeapAlloc is a gauge metric, diffing resulted in negative "heap allocated" reported metrics.
conv.ToString replaced with explicit printf verbs.
strcoll.SplitKV replaced with use of strings.IndexRune and explicit handling of missing separator
strcoll.Tuples replaced with tabwriter and explicit printf verbs