[cisco_asa] Loosen a grok pattern for a Customer issue - Githubissues

elastic / integrations

Elastic Integrations

https://www.elastic.co/integrations

Other

186 stars 387 forks source link

[cisco_asa] Loosen a grok pattern for a Customer issue #10243

Closed jrmolin closed 3 days ago

jrmolin commented 3 days ago

bugfix

Proposed commit message

[cisco_asa] Loosen grok patterns for 725007 (and similarly patterned) messages to correct matching misses

Ensure that the loosening does not match invalid lines
Add sample logs

Checklist

[x] I have reviewed tips for building integrations and this pull request is aligned with them.
[x] I have verified that all data streams collect metrics or logs.
[x] I have added an entry to my package's changelog.yml file.
[x] I have verified that Kibana version constraints are current according to guidelines.

Related Issues

https://github.com/elastic/sdh-beats/issues/4848

elasticmachine commented 3 days ago

:rocket: Benchmarks report

To see the full report comment with /test benchmark fullreport

jrmolin commented 3 days ago

One more iteration, then I'll merge, if it passes CI

elastic-sonarqube[bot] commented 3 days ago

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

elasticmachine commented 3 days ago

:green_heart: Build Succeeded

Buildkite Build
Commit: 5e335b2baea0abbeb97c3b4db9f77d1e96184f5e

History

:green_heart: Build #12863 succeeded 8a09e807efeac6ed6c2ab85e1cde8ffb2a062a40
:broken_heart: Build #12857 failed 5aa968b853e0869a992933340867750b7d6c341b
:broken_heart: Build #12854 failed 002a958d459b0f20fba10b6f669f487e6791b8b5

cc @jrmolin

elasticmachine commented 3 days ago

Package cisco_asa - 2.35.2 containing this change is available at https://epr.elastic.co/search?package=cisco_asa