elastic / integrations

Elastic Integrations
https://www.elastic.co/integrations
Other
196 stars 424 forks source link

[Kubernetes Integration] Updating kubernetes volume dashboard #10267

Closed gizas closed 2 months ago

gizas commented 3 months ago

Proposed commit message

Notes:

Checklist

How to test this PR locally

Related issues

Screenshots

Screenshot 2024-06-26 at 12 13 22 PM

Screenshot 2024-06-26 at 12 13 44 PM

elasticmachine commented 3 months ago

:rocket: Benchmarks report

To see the full report comment with /test benchmark fullreport

tetianakravchenko commented 2 months ago

@gizas there is smth wrong: before this PR - there were 2 vizualisations:

Screenshot 2024-07-05 at 14 06 37

after - 3 with wrong formating, one of them is a duplication:

Screenshot 2024-07-05 at 14 08 20
tetianakravchenko commented 2 months ago

after clarification:

  1. please add a title for the new vizualisation - like Volume usage [Metrics Kubernetes] (similar to other names)
  2. clarify if pod name should be added to the Filesystem Inodes Informations [Metrics Kubernetes] and Filesystem Informations [Metrics Kubernetes] vizualisations as well
gizas commented 2 months ago

@eedugon lets clarify above questions: https://github.com/elastic/integrations/pull/10267#issuecomment-2210794216 For me the Filesystem Innformation related Visulaisations are general and should remain like that and the first visualisation for pods is enough to have the categories you want. WDYT?

I have added title Volume Usage per Pod[Metrics Kubernetes]

elasticmachine commented 2 months ago

:green_heart: Build Succeeded

History

elastic-sonarqube[bot] commented 2 months ago

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
98.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

gizas commented 2 months ago

Synced with @eedugon offline. There was a comment to change the filter of visualisation to metricset.name but we decide not. Reason was to keep it aligned as per other dashboards that have data_stream.dataset used.

This dashboard might need another update when the type of volume will be intorduced

elasticmachine commented 2 months ago

Package kubernetes - 1.66.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes