elastic / integrations

Elastic Integrations
https://www.elastic.co/integrations
Other
30 stars 448 forks source link

Add support of Processors in all the Observability Integrations #10393

Open ishleenk17 opened 4 months ago

ishleenk17 commented 4 months ago

Processors are used to provide the ability to the user to enrich their data. Currently, there is inconsistency in the Integrations wrt availability of Processors.

Expectation: Processors yaml box like below should be present in all Integrations

Screenshot 2024-07-05 at 12 12 16 PM
Linu-Elias commented 4 months ago

The list of packages with missing processor:

ishleenk17 commented 4 months ago

@Linu-Elias :Lets organize it at package level. I have done that for some in above comment

ali786XI commented 4 months ago

As I was reviewing some of the PRs related to processors raised by third party contributors, I just want to list them so that we can possibly reduce some of them in our ones.

shmsr commented 4 months ago

@Linu-Elias Just curious. Are the changes done manually or you used any existing/new automation to do this change?

Linu-Elias commented 4 months ago

@shmsr I wrote a script to first fetch those packages that had missing processors and adding the processors by the same code, but updating changelog and manifest was done manually.

shmsr commented 4 months ago

@shmsr I wrote a script to first fetch those packages that had missing processors and adding the processors by the same code, but updating changelog and manifest was done manually.

Great! If the code is sufficient to perform the task on all packages safely and you believe it would be beneficial for others, you can open a pull request in this repository: https://github.com/elastic/obs-integrations-robots.

If not, that's okay too. However, it's great to have reliable automation tools that are generally useful, like this one: https://github.com/andrewkroh/go-examples/tree/main. We sometimes use tools created primarily by Andrew to execute extensive automation changes.

ali786XI commented 4 months ago

As we have reached the last PR on this should we include the vsphere package changes in the final PR or try to push the PR from the collaborator?

ishleenk17 commented 4 months ago

As we have reached the last PR on this should we include the vsphere package changes in the final PR or try to push the PR from the collaborator?

The community PR has been blocked on CLA agreement, so I think it's ok to have vsphere as part of this meta issue. You can link this issue in community PR.