carbon_black_cloud: fix timestamp type when using cursor value

efd6 commented 1 month ago

Proposed commit message

When using the cursor value, the start expression in the range macro is a string since state.cursor.last_backend_update_timestamp is a string. This results in a comparison of range.start (string) with range.end (timestamp) which is not a valid type match for the \< operator. So we end up with a "no such overload". If the value is optional.none, we use delayed (timestamp) which is the correct type. Ensure that the expression is always a timestamp by doing a conversion on the resulting value, noting that a timestamp(timestamp(x)) is valid if timestamp(x) is.

Checklist

[ ] I have reviewed tips for building integrations and this pull request is aligned with them.
[ ] I have verified that all data streams collect metrics or logs.
[ ] I have added an entry to my package's changelog.yml file.
[ ] I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

[ ]

How to test this PR locally

Related issues

Screenshots

elastic-vault-github-plugin-prod[bot] commented 1 month ago

:rocket: Benchmarks report

Package `carbon_black_cloud` :+1:(3) :green_heart:(2) :broken_heart:(1)

Expand to view

Data stream | Previous EPS | New EPS | Diff (%) | Result ----------- | ------------ | ------- | -------- | ------ `asset_vulnerability_summary` | 14492.75 | 10869.57 | -3623.18 (-25%) | :broken_heart:

To see the full report comment with /test benchmark fullreport