elastic / integrations

Elastic Integrations
https://www.elastic.co/integrations
Other
30 stars 447 forks source link

[CrowdStrike] Add Support of Crowdstrike Event Stream #11773

Open mohitjha-elastic opened 3 days ago

mohitjha-elastic commented 3 days ago

Type of change

Proposed Commit Message

Add support of new input type to collect logs for the falcon dataset- CrowdStrike Event Stream via streaming input. Update the minimum kibana version to 8.16.0 Add the entry of the crowdstrike event stream in readme

Checklist

Screenshots

image image

elasticmachine commented 3 days ago

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

mohitjha-elastic commented 2 days ago

There are not tests here. Can you remove the comment in the PR that says how to test locally since that obviously has no effect on this addition.

Have you tested? What do you need in order to add CI testing?

Thank you for pointing that out! I've removed the comment from the PR description.

It has been tested on the CrowdStrike Live Instance using the Event Stream API. I am under the impression that system testing for streaming is not yet supported.

efd6 commented 2 days ago

I am under the impression that system testing for streaming is not yet supported.

As far as the input is concerned, chunked and non-chunked connections are the same. It should be possible to simulate the behaviour of the API with stream as it currently exists.

efd6 commented 2 days ago

/test

elastic-vault-github-plugin-prod[bot] commented 1 day ago

:rocket: Benchmarks report

To see the full report comment with /test benchmark fullreport

elasticmachine commented 1 day ago

:green_heart: Build Succeeded

elastic-sonarqube[bot] commented 1 day ago

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube