elastic / integrations

Elastic Integrations
https://www.elastic.co/integrations
Other
28 stars 444 forks source link

[LastPass] Update data collection after resolve request_body_on_pagination issue #4256

Open vinit-chauhan opened 2 years ago

vinit-chauhan commented 2 years ago

Currently, in the LastPass integration, the time fields are stored in the request body of a POST call under the following keys data.from and data.to.

For the pagination, we tried accessing the last response's body in the pagination section with the help of request_body_on_pagination. But we were not able to access the last response body. So for that, we have raised an issue in beats.

However, in the meantime, we are storing the time parameter which is required for pagination, into the URL query parameter. The URL parameters are accessible in the pagination section. However, The ideal way is to access parameters from the request body itself.

This issue here is to update the data collection with such logic, after the resolution of the above-mentioned beats issue, we have to update the data collection.

Here, I am mentioning LastPass public API link.

Related issues

elasticmachine commented 2 years ago

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

jamiehynds commented 1 year ago

@piyush-elastic not sure if this is still relevant. Will assign to you, but free to close if it's no longer valid.