Open 111andre111 opened 1 year ago
Hi! We just realized that we haven't looked into this issue in a while. We're sorry! We're labeling this issue as Stale
to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1
. Thank you for your contribution!
Synopsis
Similar to https://github.com/elastic/integrations/pull/6767 please review the reset of the integrations for similar occasions
Code Places
A first investigation I did was that following places have as well a add_locale processor as the last place after custom processors section: https://github.com/elastic/integrations/blob/783e49cdff126f544233ba04170bec87d36c3265/packages/fortinet_fortiedr/data_stream/log/agent/stream/udp.yml.hbs#L17 https://github.com/elastic/integrations/blob/783e49cdff126f544233ba04170bec87d36c3265/packages/iptables/data_stream/log/agent/stream/udp.yml.hbs#L19 https://github.com/elastic/integrations/blob/783e49cdff126f544233ba04170bec87d36c3265/packages/juniper_srx/data_stream/log/agent/stream/logfile.yml.hbs#L20 https://github.com/elastic/integrations/blob/783e49cdff126f544233ba04170bec87d36c3265/packages/keycloak/data_stream/log/agent/stream/filestream.yml.hbs#L20 https://github.com/elastic/integrations/blob/783e49cdff126f544233ba04170bec87d36c3265/packages/modsecurity/data_stream/auditlog/agent/stream/stream.yml.hbs#L21 https://github.com/elastic/integrations/blob/783e49cdff126f544233ba04170bec87d36c3265/packages/mysql_enterprise/data_stream/audit/agent/stream/stream.yml.hbs#L20 https://github.com/elastic/integrations/blob/783e49cdff126f544233ba04170bec87d36c3265/packages/netscout/data_stream/sightline/agent/stream/udp.yml.hbs#L3627 https://github.com/elastic/integrations/blob/783e49cdff126f544233ba04170bec87d36c3265/packages/nginx/data_stream/error/agent/stream/stream.yml.hbs#L27 https://github.com/elastic/integrations/blob/783e49cdff126f544233ba04170bec87d36c3265/packages/oracle/data_stream/database_audit/agent/stream/stream.yml.hbs#L25 https://github.com/elastic/integrations/blob/783e49cdff126f544233ba04170bec87d36c3265/packages/rabbitmq/data_stream/log/agent/stream/log.yml.hbs#L27 https://github.com/elastic/integrations/blob/783e49cdff126f544233ba04170bec87d36c3265/packages/snort/data_stream/log/agent/stream/udp.yml.hbs#L19 https://github.com/elastic/integrations/blob/783e49cdff126f544233ba04170bec87d36c3265/packages/sophos/data_stream/xg/agent/stream/log.yml.hbs#L20 https://github.com/elastic/integrations/blob/783e49cdff126f544233ba04170bec87d36c3265/packages/sophos/data_stream/xg/agent/stream/udp.yml.hbs#L20 ~https://github.com/elastic/integrations/blob/783e49cdff126f544233ba04170bec87d36c3265/packages/squid/data_stream/log/agent/stream/stream.yml.hbs#L3057~ https://github.com/elastic/integrations/blob/783e49cdff126f544233ba04170bec87d36c3265/packages/ti_recordedfuture/data_stream/threat/agent/stream/logfile.yml.hbs#L20
Some of these integrations don't have a custom YAML section preparation which might be cool to consider for some of them. E.g.: https://github.com/elastic/integrations/blob/783e49cdff126f544233ba04170bec87d36c3265/packages/zoom/data_stream/webhook/agent/stream/http_endpoint.yml.hbs#L35
Purpose
I am aware some of these integrations will be reviewed or go legacy or refactored. But I wanted to to raise that issue in a more global way.
Thanks a lot.