search

elastic / jarvis

Logstash's ChatOps bot, J.A.R.V.I.S.
42 stars 28 forks source link

LS default (6.5.4) is problematic #102

Closed kares closed 4 years ago

kares commented 4 years ago

what is weird that few publish-es went fine since deploying https://github.com/elastic/jarvis/pull/100 lately we've run into issues doing a following publish: 

@jarvis publish --no-check-build https://github.com/logstash-plugins/logstash-input-file
{:timestamp=>"2020-02-20T09:37:20.341553+0000", :message=>"Using /home/jarvis/.rvm/gems/jruby-9.1.14.0", :level=>:info, :operation=>"publish", :branch=>"master", :command=>"ruby -rbundler/setup -S rake vendor"}
{:timestamp=>"2020-02-20T09:37:28.278378+0000", :message=>"Bundler::GemspecError: ", :level=>:error, :operation=>"publish", :branch=>"master", :command=>"ruby -rbundler/setup -S rake vendor"}
{:timestamp=>"2020-02-20T09:37:28.278539+0000", :message=>"[!] There was an error while loading `logstash-core-plugin-api.gemspec`: No such file or directory - /tmp/d20200220-21635-12ewkt9/logstash-6.5.4/logstash-core-plugin-api/versions-gem-copy.yml. Bundler cannot continue.", :level=>:error, :operation=>"publish", :branch=>"master", :command=>"ruby -rbundler/setup -S rake vendor"}
kares commented 4 years ago

this is due LS 6.5.4 release missing /logstash-6.5.4/logstash-core-plugin-api/versions-gem-copy.yml

kares commented 4 years ago

let's do a work-around as this has been only 'fixed' in 6.7.0 ... cp-ing the file over if missing. so that its less confusing when runing against older LS versions.

colinsurprenant commented 4 years ago

I believe this is the symptom?

Colin Surprenant @jarvis publish --no-check-build https://github.com/logstash-plugins/logstash-codec-csv
17:45
jarvisAPP :ninja: Trying to publish logstash-plugins/logstash-codec-csv from the following branches: master
17:45
Running command: bundle install
17:46
Running command: ruby -rbundler/setup -S rake vendor
17:46
:sadpanda: An error occurred in publish: Jarvis::SubprocessFailure - subprocess failed with code 1
kares commented 4 years ago

yes, likely the exit code was 1 for these cases until deployed you can work-around setting a different (newer) LS for the build e.g.

@jarvis publish --no-check-build --env "LOGSTASH_SOURCE=1 LOGSTASH_PATH=RELEASE@6.8.6" ...
kares commented 4 years ago

re-deployed jarvis with the fix