search

elastic / jarvis

Logstash's ChatOps bot, J.A.R.V.I.S.
41 stars 28 forks source link

Auto-closing Github issues #55

Open w33ble opened 8 years ago

w33ble commented 8 years ago

Our pre-Jarvis workflow was to use the merge button on github, which would auto-close the issue based on the PR's description (using Closes/Fixes/Resolves #xxxx). In the post-Jarvis world, where we don't use the merge button, Github doesn't auto-close the issue for us.

I noticed after using Jarvis to merge and backport elastic/kibana#5509 that the issue it closed (here) was left open.

Is it possible to configure Jarvis to parse the PR's description the same way Github does internally and close the issue(s) that the PR relates to?

ph commented 8 years ago

That shouldn't be an hard problem solve and it makes sense!

w33ble commented 8 years ago

Note for parsing: sometimes we close multiple issues in a single PR, in which case the list of issues will be on a single line, comma delimited. For example:

Closes #123, #456 and #789

May or may not include the "and". The important bits are single line, starting with Closes/Fixes/Resolves and parsing all #xxx patterns on that line.

spalger commented 8 years ago

This would be solved if https://github.com/elastic/jarvis/issues/54 was implemented

epixa commented 8 years ago

I think #54 is the way to go here. Let github do the work.

w33ble commented 8 years ago

54 ftw