elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.65k stars 8.23k forks source link

[Discover] scrolling down to result not available on small screen #100329

Open jmartin51 opened 3 years ago

jmartin51 commented 3 years ago

Kibana version: 7.12.x

Browser version: Chrome Version 90.0.4430.212

Describe the bug: When using small screen and lots of filter it is possible scroll down to result in 7.12.1 . It was working fine in previous version, I tried in 7.5.2 and scroll down to the result is working fine. You can have a look to the screenshot for the repro. Indeed you can see that the scrolling bar on right side is at the bottom, and unable to scroll down to see the result (even with the mouse wheel).

Workaround is to hide the chart or reduce the width of the window to switch to mobile friendly mode.

Expected behavior: Being able to scroll down in the result

Screenshots (if relevant): Screenshot 2021-05-19 at 11 56 19

elasticmachine commented 3 years ago

Pinging @elastic/kibana-app (Team:KibanaApp)

kertal commented 3 years ago

FYI @andreadelrio, although this is not a 100% solution, i think we should scale the histogram when there's little vertical space available? Don't think it's a problem limited to Discover that you can have an infinite number of filters, all being rendered, eating up lot's of vertical space

kertal commented 3 years ago

Another related issue that's being fixed here: https://github.com/elastic/kibana/pull/97634, scrolling the classic table down didn't trigger displaying more than 50 documents when there was little vertical space available

mbondyra commented 3 years ago

Reserving for mob-programming session.

ryankeairns commented 3 years ago

Let's be considerate of the fact that what we do here - if it involves changes to the UX of the search/filter bar - has a wide reach. It's temping to just dive into a solution, but I suggest employ some caution and think through our options. :)

markov00 commented 3 years ago

Let's be considerate of the fact that what we do here - if it involves changes to the UX of the search/filter bar - has a wide reach. It's temping to just dive into a solution, but I suggest employ some caution and think through our options. :)

Just my 2 cents here: I also struggle with Discover when exploring, because the scroll involves scrolling everything, both the filter/query bar and the field list on the left. This usually slows down the exploration because I need to scroll up every time I need to change the filter or a query or add a new field as a column. Some competitors use to keep fixed the filter/query and field list letting just the table scroll up and down (see Splunk). I know that this doesn't solve the mentioned issue, but I think it is a good thing to consider when refactoring the scrolling behavior of discover

mbondyra commented 3 years ago

Hi @ryankeairns and @markov00 we just had a mob programming session where we went through multiple solutions as a start. We were thinking about:

  1. Scrolling the chart along with the datagrid to increase scrollable space
  2. Making the height of the chart dependant on the space left after calculating how much space the header with filter occupy (we'll call this space 'app space')
  3. Collapse filters bar

We chose to explore the third option during our session. There were couple of approaches we thought about: a. automatically detect multiline filters and collapse it if they take a lot of lines (we decided not to follow this path) b. allow user to manually collapse filters bar to one horizontally scrollable line. The result is this PR: https://github.com/elastic/kibana/pull/101386 We added an extra option collapse bar to the filters options popover that is saved across the apps in the local storage.

I am now unassigning myself from this issue, hopefully someone from the Discover team will take over.

elasticmachine commented 3 weeks ago

Pinging @elastic/kibana-visualizations (Team:Visualizations)

kertal commented 3 weeks ago

relabeling / reassigning this issue, since the problem of having this amount of filters is surfacing in Disocver, and I'm pretty sure it will be resolved in the further iterations of UnifiedSearch