elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.73k stars 8.14k forks source link

[Fleet] Rename agent status Inactive #100899

Open nchaulet opened 3 years ago

nchaulet commented 3 years ago

Description

When an agent is unenroll we keep the agent data and we mark the agent as inactive This status is kind of confusing and we had to explain it a few times https://github.com/elastic/kibana/issues/100758 @mostlyjason what do you think of renaming that status, maybe unenrolled will be better?

As part of this we will probably have to update a few places:

elasticmachine commented 3 years ago

Pinging @elastic/fleet (Team:Fleet)

mostlyjason commented 3 years ago

I agree that unenrolled is more clear because its more specific. I'm not sure this should be a top priority though. We are focusing most of our effort currently on making it easier to enroll agents, rather than manage unenrolled ones.

nchaulet commented 3 years ago

Yes I totally agree this should not be a high priority

lucabelluccini commented 1 year ago

While inactive/unenrolled agents are not shown by default, the documents accumulate over time and especially for users installing Elastic Agents on ephemeral hosts (containers, vms) where the ID gets regenerated at each new spawn or restart (also in Elastic Cloud for our Integration Server), this can be a problem over long periods of time. A user would end up having thousands of documents in the Fleet indices just because they recycled a VM or a container 1000 times.

If we try to delete via the Fleet API, e.g. curl -X DELETE /api/fleet/agents/fb119d4c-0470-4c40-bf82-5a8063d313b9 -Hkbn-xsrf:fleet, we get a {"action":"deleted"} response and if we do a curl /api/fleet/agents/fb119d4c-0470-4c40-bf82-5a8063d313b9 we still get the document.