search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.67k stars 8.23k forks source link

Remove SLM multiple policy restriction #101007

Open nickofthyme opened 3 years ago

nickofthyme commented 3 years ago

Kibana elasticsearch UI limits the number of concurrently scheduled snapshots in the code below...

image

https://github.com/elastic/kibana/blob/0cf48f3ecfd999053e4583088600fbb134bb0db7/x-pack/plugins/snapshot_restore/public/application/sections/home/policy_list/policy_list.tsx#L156-L175

However, per discussion on slack It appears that elasticsearch is capable of concurrent snapshots as of the next release 7.13.1, per https://github.com/elastic/elasticsearch/pull/73456.

You can run multiple snapshots and snapshot deletes in parallel these days (in fact ever since 7.9). That said there have been a few hiccups with concurrent snapshot execution where rare bugs caused trouble. But upcoming 7.13.1 has no remaining known issues with it.

This should be tested to confirm no issues exist when removing aforementioned code.

Note: supported since elasticsearch@7.9.0 see https://github.com/elastic/elasticsearch/pull/56911

elasticmachine commented 3 years ago

Pinging @elastic/es-ui (Team:Elasticsearch UI)

geekpete commented 3 years ago

You might still conditionally show a warning if the number of overlapping policies is greater than the configured concurrent snapshot setting value? snapshot.max_concurrent_operations

You can start multiple snapshot operations at the same time. Concurrent snapshot operations are limited by the snapshot.max_concurrent_operations cluster setting, which defaults to 1000. This limit applies in total to all ongoing snapshot creation, cloning, and deletion operations. Elasticsearch will reject any operations that would exceed this limit. https://www.elastic.co/guide/en/elasticsearch/reference/current/snapshots-take-snapshot.html#create-snapshot-process-details

For example, if a user has set this to 1 then the warning would be pertinent rather than end up with a bunch of failing snapshots...possibly also non-deterministically failing if there's any race condition of which snapshot policy actually gets to run if snapshot policies have the same start time configured.

leandrojmp commented 1 year ago

Hello,

Is there any update about this issue? I'm on 8.5.1 and still get this message.

nickofthyme commented 1 year ago

@elastic/platform-deployment-management

alisonelizabeth commented 1 year ago

Is there any update about this issue? I'm on 8.5.1 and still get this message.

No updates on this issue yet. While I agree the message is confusing, it should not affect the snapshots themselves.

leandrojmp commented 8 months ago

Hello,

This still happens on 8.12.1

elasticmachine commented 2 months ago

Pinging @elastic/kibana-management (Team:Kibana Management)