Open clintandrewhall opened 3 years ago
Pinging @elastic/security-solution (Team: SecuritySolution)
Pinging @elastic/kibana-gis (Team:Geo)
Pinging @elastic/app-search-frontend (Team:AppSearch)
Pinging @elastic/kibana-stack-management (Team:Stack Management)
Pinging @elastic/workplace-search-frontend (Team:WorkplaceSearch)
I am removing "Team:geo" tag from this issue since Maps usage is a type only import
Enterprise Search (App Search and Workplace) Search only uses the library for types (example). Looks like EUI exports one of the ones we use so I put up a PR for that one.
Added a PR to get DraggableProvidedDragHandleProps
. I believe that Enterprise Search can completely drop the library. cc @constancecchen
@nreese Can those types be imported from EUI instead? I'd love to remove this library from the package.json
file entirely.
Looks like you'll be able to soon: https://github.com/elastic/eui/pull/4903
As I discovered in https://github.com/elastic/kibana/pull/102688, Canvas was using
react-beautiful-dnd
for its Drag n' Drop functionality. It turns out EUI Drag n' Drop uses it under the hood.Unless I'm reading it incorrectly, we saved 377k from one of our async bundles with this replacement, and removed an external dependency in the process.
Searching the code, the following solutions use
react-beautiful-dnd
:I found replacement in Canvas to be incredibly easy. Other teams may find the same, and save nearly 400k in the process.