search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.72k stars 8.14k forks source link

[Maps] EMS-client requires additional license override #102909

Open thomasneirynck opened 3 years ago

thomasneirynck commented 3 years ago

The ems-client requires an additional license override in https://github.com/elastic/kibana/blob/master/src/dev/license_checker/config.ts#L76

There seems to be something with the 7.14 version of the ems-client: https://github.com/elastic/kibana/pull/102770

Ideally, this override can be removed. Otherwise it always needs to be updated anytime the ems-client is upgraded.

elasticmachine commented 3 years ago

Pinging @elastic/kibana-gis (Team:Geo)

jsanz commented 3 years ago

This is probably due to not having the proper license definition in ems-client

https://github.com/elastic/ems-client/blob/930f2552a691fb69b9a3b4097e963fef3667e06f/package.json#L27

"license": "SEE LICENSE IN LICENSE.txt",

that is also being reflected in npmjs landing page

image

I'll open a PR to get it fixed, sorry for the inconvenience

nickpeihl commented 3 years ago

The NPM docs suggest using SEE LICENSE IN <filename> for non-SPDX licenses which is why it was set that way. But that conflicts with Kibana's license checker. 🤷

I suspect we'll see a warning from yarn or kibana whichever property we use for license.

thomasneirynck commented 3 years ago

bumping. Will do change in 7.15.

nickpeihl commented 3 years ago

The @elastic/eui and @elastic/charts libraries are experiencing similar issues. See https://github.com/elastic/kibana/issues/105614

elasticmachine commented 1 year ago

Pinging @elastic/kibana-presentation (Team:Presentation)