elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.72k stars 8.14k forks source link

Select text to copy buffer does not work on Linux for Dev Console #105416

Open robin13 opened 3 years ago

robin13 commented 3 years ago

Kibana version: 7.13.2

Elasticsearch version: 7.13.2

Server OS version: Ubuntu 20.04.2 LTS with kernel 5.4.0-77-generic

Browser version: Mozilla Firefox 89.0.2

Browser OS version: Ubuntu 20.04.2 LTS with kernel 5.4.0-77-generic

Original install method (e.g. download page, yum, from source, etc.): Docker image

Describe the bug:

On Linux you can generally select any text; this text is inserted into a buffer, and you can quickly paste this text with the middle mouse button. This works on all applications on all linux variants I have used. It does not work in Kibana for the Dev Console or Discover tab in the JSON document view.

Here is a screen recording to illustrate: https://drive.google.com/file/d/1Qc3EVrphO1_5xDmBQAdBq29f3QPKNmSl/view?usp=sharing

timroes commented 3 years ago

This is caused by monaco editor for some reason not working with Selection in Linux in Firefox. In Chrome this seems to work perfectly fine, so I am not sure if it's actually something Monaco editor can actually fix. Given that the same behavior happens for me on https://microsoft.github.io/monaco-editor/ I think this is an upstream issue and not specific to Kibana.

timroes commented 3 years ago

I found https://github.com/microsoft/monaco-editor/issues/1943 which seems to track this. I'll be closing this in favor of this, since there's nothing we can do at the moment. And in case Monaco finds a fix for that, we're anyway staying up to date with newer monaco versions.

timroes commented 3 years ago

Reopening. After talking offline a bit (Internal Slack link), there seem to be different behaviors across different Linux distributions at least we're seeing different behaviors using the same browser in Kibana's Console. This might be worth investigating more.

elasticmachine commented 3 years ago

Pinging @elastic/kibana-stack-management (Team:Stack Management)

mibragimov commented 2 years ago

This seems like an Ace editor issue, should we try to fix a patch for it or skip it for now in favor of future migration to Monaco? @cjcenizal

cjcenizal commented 2 years ago

Let's keep this open for now. Once we migrate to Monaco we can verify the migration fixes this issue.

yuliacech commented 1 month ago

This bug might have been fixed by the migration, but needs to be verified on a Linux machine

elasticmachine commented 2 days ago

Pinging @elastic/kibana-management (Team:Kibana Management)