search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.69k stars 8.11k forks source link

License checker incorrectly detects EUI as Apache #105614

Open chandlerprall opened 3 years ago

chandlerprall commented 3 years ago

Originally pointed out in https://github.com/elastic/kibana/pull/105127#issuecomment-877515410 [and this will also affect the charts library]

Starting in v35, we're using "license": "SEE LICENSE IN LICENSE.txt", in EUI's package.json to avoid npm/yarn's warning about a non-SPDX license (https://github.com/npm/npm/issues/8795). However, the license-checker module used by Kibana falls back to a regex test which is detecting the Apache mention in LICENSE.txt

I could check with legal about removing the Apache part from our license notice, but even so I believe license-checker wouldn't pick up the correct license as it has no knowledge of ELv2 or SSPL.

Another thought I had is to expand Kibana's license overrides logic to allow version ranges, e.g. @elastic/eui@>=35.0.0 instead of requiring exact matches.

elasticmachine commented 3 years ago

Pinging @elastic/kibana-operations (Team:Operations)

ghudgins commented 3 years ago

There is a similar issue in https://github.com/elastic/elastic-charts - @markov00 and I will 👀 this for the solution we should also incorporate there as well