search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.77k stars 8.17k forks source link

[Ingest Node Pipelines] Improve script processor UX #105803

Open alisonelizabeth opened 3 years ago

alisonelizabeth commented 3 years ago

The current UX when creating a script processor via the Ingest Node Pipelines UI can be improved.

Related to comments mentioned on https://github.com/elastic/kibana/issues/105759#issuecomment-880828310.

Suggested changes:

  1. Change the "Language" text field to a dropdown. Per the docs, the accepted languages are: painless, expression, java and mustache. The default selection should be painless.
Screen Shot 2021-07-15 at 12 24 18 PM
  1. Improve help text or better associate the "Language" field with the "Source" field. There are two places that accept a script - "Source" and "Condition". The language defined in the "Language" field only affects the "Source" field. The "Condition" field must always be written in Painless (per the docs). It's not clear in the current UI that this is the case.

Ingest-Node-Pipelines-Elastic

elasticmachine commented 3 years ago

Pinging @elastic/kibana-stack-management (Team:Stack Management)

alisonelizabeth commented 3 years ago

/cc @dborodyansky curious on your thoughts on how to best address the second point in this issue.

dborodyansky commented 3 years ago

@alisonelizabeth Here are some options that come to mind regarding language selection hierarchy. What do you think? image

alisonelizabeth commented 3 years ago

These look great! Thanks @dborodyansky. I think I like option B or C, although any of them I think would be an improvement over the current experience. Is there one you were leaning more toward?

dborodyansky commented 3 years ago

@alisonelizabeth I touched base to get some input from other designers, and recommend option C.

elasticmachine commented 2 weeks ago

Pinging @elastic/kibana-management (Team:Kibana Management)