[Dashboard] Link to editors in read-only mode

elastic / kibana

Your window into the Elastic Stack

https://www.elastic.co/products/kibana

Other

19.64k stars 8.22k forks source link

[Dashboard] Link to editors in read-only mode #106553

Open rayafratkina opened 3 years ago

rayafratkina commented 3 years ago

Problems: We want to solve two different problems in this issue:

When users have read-only access to dashboards they cannot manipulate visualizations to run their investigations or even see their configuration (dataviews and fields used, formulas, etc.). This is always the case with "Managed" dashboards.
When users have edit access but the dashboard is in view mode, they need to first realize they are in view mode, then click "edit" on the dashboard, open the visualization menu and click "edit" again, making sure they don't forget to cancel any accidental changes. This is too many clicks and they don't have any way to only see the configuration without the risk of making any changes.

Solutions:

When users have read-only access, we will allow them to view and configure visualizations, but they won't be able to save these changes.
When users have edit access --> solution definition WIP and it will be a separate issue.

elasticmachine commented 3 years ago

Pinging @elastic/kibana-presentation (Team:Presentation)

elasticmachine commented 3 years ago

Pinging @elastic/kibana-app (Team:KibanaApp)

cqliu1 commented 1 year ago

This should be fairly easy to implement at the Dashboard side, but on the editor side, what should the user have access to in a view-only mode of the editors. Do we allow them full access to the editor (within their user privileges) but block them from saving any changes made and only return to the dashboard? So instead of Save and Return, we'd have only Return to dashboard.

This would require changes in all the editors to allow a return only workflow. Is this worth exploring?

philippkahr commented 9 months ago

I would also like to click on a visualisation in a managed dashboard. Open the Lens editor, as I know it. This would allow me to understand what fields are used, what calculation type. I don't need to edit it there. Since I am already in Lens I could also copy the visualisation to my own custom dashboard.

IanLee1521 commented 9 months ago

Agreed. This is particularly useful for managed dashboards where I just want to know how a panel was created (maybe so I can make something like it elsewhere) but I'm not ready to do a full: clone > edit > inspect > delete the copy workflow. Some way to just view the panel configuration would be great. That could be in Lens or elsewhere even.

flash1293 commented 8 months ago

To make the scope more manageable, what about just solving this for the managed dashboard case and Lens visualization panels?

MichaelMarcialis commented 4 months ago

The latest design mockups for this issue have been crafted and are ready for handoff to engineering. Some key screenshots from the mockups can be found below. Please view the full Figma document for all mockups and developer notes.

mbondyra commented 2 months ago

After initial draft I realized this is heavily conflicting with embeddable refactor for Lens, so we'll wait with working on this issue till https://github.com/elastic/kibana/pull/186642 is merged.