"Buffer" polyfill bloats plugin bundles

Dosant commented 3 years ago

When Buffer is used in client or common code, webpack bundles a costly ~30kb polyfill. Looks like it does it per each plugin where Buffer is used. In some cases, it is possible to avoid using it in clientside code altogether, but probably we at least could share the Buffer polyfill across plugins.

Screen Shot 2021-07-30 at 13 07 17

Some clientside usages I found:

[ ] Core https://github.com/elastic/kibana/blob/3c3087855ff00d2fac945192a1aeebdf70d209e4/src/core/public/utils/crypto/sha256.ts#L164
[ ] Canvas https://github.com/elastic/kibana/blob/57a53dbbb65cc99f795bcfcc9d6f28eb41ae4e16/x-pack/plugins/canvas/common/lib/embeddable_dataurl.ts#L10-L13
[ ] Enterprise Search https://github.com/elastic/kibana/blob/6f5cd00d1fce251ddcddf5808fc8b3a7c638c061/x-pack/plugins/enterprise_search/public/applications/app_search/components/document_creation/document_creation_logic.ts#L172
[ ] Fleet https://github.com/elastic/kibana/blob/4681a80317176543535bfdb2188d94aa40d741fc/x-pack/plugins/fleet/common/services/decode_cloud_id.ts#L29
[ ] Fleet (should use global.Buffer to avoid webpack from polyfilling it) https://github.com/elastic/kibana/blob/4584a8b570402aa07832cf3e5b520e5d2cfa7166/x-pack/plugins/fleet/common/services/is_valid_namespace.ts#L39
[ ] Lists (it's in the common dir. Is it actually used in the Browser?) https://github.com/elastic/kibana/blob/9bf488e8261196ea48a43fad25c2cc1c9395f5a1/x-pack/plugins/lists/common/schemas/request/import_list_item_schema.mock.ts#L19-L21
[ ] Maps https://github.com/elastic/kibana/blob/3730dd0779ed8efd74aee88f57422781ec1ac122/x-pack/plugins/maps/public/routes/map_page/saved_map/saved_map.ts#L58
[ ] Maps https://github.com/elastic/kibana/blob/3730dd0779ed8efd74aee88f57422781ec1ac122/x-pack/plugins/maps/public/routes/map_page/saved_map/saved_map.ts#L472
[x] Synthetics https://github.com/elastic/kibana/blob/80a2aa1f743421fbb8a071c60731e64b4f1768f8/x-pack/plugins/synthetics/public/components/monitor_management/action_bar/action_bar.tsx#L68
[x] Synthetics https://github.com/elastic/kibana/blob/80a2aa1f743421fbb8a071c60731e64b4f1768f8/x-pack/plugins/synthetics/public/components/monitor_management/monitor_list/actions.tsx#L48
[x] Synthetics https://github.com/elastic/kibana/blob/a4a082271e1f5f15a8a49206dd4ce72e950de413/x-pack/plugins/synthetics/public/pages/monitor_management/edit_monitor.tsx#L34
[ ]
[x] Data (should be easy to remove. Trying now) https://github.com/elastic/kibana/pull/107278#pullrequestreview-718974155 https://github.com/elastic/kibana/blob/3c3087855ff00d2fac945192a1aeebdf70d209e4/src/plugins/data/common/field_formats/converters/string.ts#L98
[x] Bfetch (should be easy to remove. Trying now) https://github.com/elastic/kibana/pull/107278#pullrequestreview-718974155 https://github.com/elastic/kibana/blob/3c3087855ff00d2fac945192a1aeebdf70d209e4/src/plugins/bfetch/public/streaming/inflate_response.ts#L12
[ ] Possibly other

elasticmachine commented 3 years ago

Pinging @elastic/kibana-operations (Team:Operations)

elasticmachine commented 3 years ago

Pinging @elastic/kibana-core (Team:Core)

elasticmachine commented 3 years ago

Pinging @elastic/kibana-app-services (Team:AppServices)

afharo commented 2 years ago

While I agree that we should avoid using it, I created https://github.com/elastic/kibana/pull/130877 to move those polyfills to the UI Shared Deps.

pgayvallet commented 2 years ago

@afharo with the polyfills being included in the shared deps, should we close this issue?

afharo commented 2 years ago

I wonder if we should keep it open to actually avoid using them and remove them from the shared deps. What do you think?