search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.65k stars 8.23k forks source link

Cleanup Monaco infrastructure #107384

Open timroes opened 3 years ago

timroes commented 3 years ago

It seems we currently have the monaco code editor split up in the @kbn/package and the parts in the kibana_react plugin. It's currently very confusing how to add new languages, since they are split up over two places, and handled very differently in those two places (in respect to web workers).

I think we should cleanup the monaco infrastructure and make sure we have one clear place that handles those things (and is obviously well documented and tested).

Also it seems the two places are currently owned by different teams, which seems to be non indeal. Pinging those two teams on this issue.

elasticmachine commented 3 years ago

Pinging @elastic/kibana-stack-management (Team:Stack Management)

elasticmachine commented 3 years ago

Pinging @elastic/kibana-app-services (Team:AppServices)

elasticmachine commented 2 years ago

Pinging @elastic/kibana-presentation (Team:Presentation)

yuliacech commented 9 months ago

Removing the Management team label since our team doesn't own the code editor anymore. The SharedUX team is aware of this issue.