search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.83k stars 8.21k forks source link

[APM] Loading message missing or inconsistent in various list views #110204

Closed formgeist closed 3 years ago

formgeist commented 3 years ago

Summary

Most of the other APM tables will show a simple loading message, but the Traces list table shows a loading spinner. We moved away from the spinners in previous releases, but it seems the table wasn't updated. We should simply display the "Loading..." default message to make it consistent with the rest. All in all, we could make this more consistent so that we always show a "Loading…" message in the list tables.

CleanShot 2021-08-26 at 11 19 49@2x

There's also no "Loading…" message shown in the Transactions, Errors, Dependencies (formerly Backends), or Instances lists.

image

CleanShot 2021-08-31 at 11 32 26@2x CleanShot 2021-08-31 at 11 32 35@2x

Also noticed that the JVMs list table doesn't show a loading state at all, just shows the empty state message until it loads the content of the table.

CleanShot 2021-08-31 at 11 33 44

Desired outcome

The current Service inventory list shows a loading message and loading indication as a continuous progress bar below the table row headers.

CleanShot 2021-08-26 at 13 30 05@2x
elasticmachine commented 3 years ago

Pinging @elastic/apm-ui (Team:apm)

MiriamAparicio commented 3 years ago

Check also the Backed page, we can add the "Loading..." message that is currently missing image.png

formgeist commented 3 years ago

@MiriamAparicio Great spot! I've updated the description to include the Backends list (now Dependencies list) and in general make this about inconsistencies in our list table loading states.

formgeist commented 3 years ago

@MiriamAparicio Had another review of our various tables and found more inconsistencies to add to the list above ^ 😬 - also there's a missing loading state in the JVMs list in the Metrics tab that we might want to take a look at in the same process.

MiriamAparicio commented 3 years ago

@formgeist I'm finding also other small differences between table lists. I can add them here or put all together in a document. What do you prefer?

formgeist commented 3 years ago

I think if it pertains to the loading message or loading experience, we can put it in this issue. Otherwise, perhaps we should open a new issue for anything else that might have come up? How does that sound?