[Pie] Remove the legacy pie chart

stratoula commented 3 years ago

The new vis_type_pie plugin was introduced on 7.14. It is the default solution for creating pie charts (for aggregation-based visualizations). A user can switch to the old implementation by using the Pie Legacy charts library advanced setting

We plan to remove the old implementation (and the advanced setting) on 8.4. One minor before, we want to inform our users about this removal. Steps we should do:

Check telemetry on the number of clusters that use the old implementation
Add notification upon the removal on the viz editor. The notification should appear for the users that use the old one. We should inform them that it will be removed on the next minor and ask them to turn the flag off
Create documentation about the new library, what offers in comparison with the old one and also known issues. On 8.1 check all the vislib pie related bugs and close them with a comment

Check this PR that added the notification for the xy axis https://github.com/elastic/kibana/pull/105055

For 8.1:

Review all reported problems
Decide targeted version for release
Implement warning banner if necessary in 8.3

Bugs that need to be solved before the removal:

https://github.com/elastic/kibana/issues/116748

elasticmachine commented 3 years ago

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

robcowart commented 3 years ago

Before the legacy pie chart is removed there are a few things that should be added to the new pie chart.

1 - The tooltip should be enhance to include the full information available in the legacy pie chart.

Legacy:

New:

The new chart lacks the useful information that can be communicated with the legacy tooltip. However in case of a nested pie chart, as above, the data provided in the legacy tooltip is not exactly accurate as it combines values from all sections where the entity occurs rather than only the inner-outer pair over which the mouse has hovered.

To summarize... the more informational tooltip style, but when nested the data should be scoped only for the related slices.

2 - The option should be provided to use a fixed width legend.

This allows for an aesthetically pleasing layout when combining multiple pie chart visualizations in a single dashboard, as was possible with the legacy chart.

Legacy:

New:

One can see how the lack of a fixed width legend in just throws off the alignment of the whole dashboard.

3 - The thickness of the donut should be configurable in the options, allowing users to choose a size more similar to legacy donut.

I recognize this is subjective, however I cannot understate my dislike for the thick donut. It is enough for me to recommend to users that they not upgrade from 7.13.4. There are some nice things about the new chart, including the nested legend option and decoupling the filtering options from the color selection. However the thick donut just ruins all of that goodness for our users.

ghudgins commented 3 years ago

stratoula commented 3 years ago

I also think that this one https://github.com/elastic/elastic-charts/issues/623 is related to this issue.

elastic / kibana