search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.64k stars 8.23k forks source link

[Observability] Observability app pages seem to all show a blank (seemingly broken) white screen for a non-existent route #113139

Closed jasonrhodes closed 1 year ago

jasonrhodes commented 3 years ago

Observability apps do not seem to attempt to handle a 404 state for a non-existent route.

See some examples Screen Shot 2021-09-27 at 11 49 55 AM Screen Shot 2021-09-27 at 11 14 39 AM

Whereas in /app, these are handled with a 404 screen:

Screen Shot 2021-09-27 at 11 50 46 AM

@smith also mentions:

it looks like behavior across apps is not consistent. /app/security/blah redirect to the overview, /app/home/blah shows that url but it’s just the home page. /app/enterprise_search/what shows application not found. /app/fleet/what redirects to /app/fleet/agents, and so on

So it's not something we handle consistently across Kibana, but we should try to be consistent within Observability and avoid the blank white screen scenario, at the very least.

AC:

We show a consistent non-blank screen for all non-existent routes across Observability apps. This should be handled at the router level for each plugin.

Thank you to @cchaos for pointing this out.

afgomez commented 1 year ago

I have created a shared <NotFound /> component in https://github.com/elastic/kibana/pull/145598 based on the EUI Guidelines for this. It can be used anywhere where an <EuiPrompt /> can be used.