search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.78k stars 8.19k forks source link

[Security Solution][Platform] - Clean up es-lint disables (no-continue) #113700

Open yctercero opened 3 years ago

yctercero commented 3 years ago

In an effort to improve code quality, platform team looked through team's linter rules and our use of es-lint-disable. There are some low hanging fruit where we could remove these instances where we've disabled rules.

Per eslint (https://eslint.org/docs/rules/no-continue) -

When used incorrectly it makes code less testable, less readable and less maintainable. Structured control flow statements such as if should be used instead.

Simply search "no-continue" within the security_solution folder. When creating this ticket, there were 3 instances of it being disabled.

elasticmachine commented 3 years ago

Pinging @elastic/security-solution (Team: SecuritySolution)

deepto98 commented 3 years ago

@yctercero Hi, I'd like to work on this issue, can you please assign this to me?