search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.61k stars 8.22k forks source link

[Snapshot & Restore] Improve readability of api integration tests #115205

Closed yuliacech closed 1 month ago

yuliacech commented 3 years ago

Snapshot & Restore uses server side pagination, sorting and search in snapshots table implemented in #110266. It's crucial that Kibana server code correctly uses Elasticsearch Get snapshot API. The API integration tests for this can be found https://github.com/elastic/kibana/tree/master/x-pack/test/api_integration/apis/management/snapshot_restore, but they are difficult to read and reason about (several snapshots, repositories and SLM policies need to be created to test pagination, sorting and search). @cjcenizal had a great idea (comment) of using concrete examples to make these tests more readable.

elasticmachine commented 3 years ago

Pinging @elastic/kibana-stack-management (Team:Stack Management)

alisonelizabeth commented 1 month ago

Closing this as not planned for now, we will continue to iterate on the tests as we work on new features and bugfixes.