elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.66k stars 8.23k forks source link

[Security Solution]Able to view Hit Enter modal and Inspect icon modal at same time after existing inspect full screen #115339

Open ghost opened 3 years ago

ghost commented 3 years ago

Describe the bug Able to view Hit Enter modal and Inspect icon modal at same time after existing inspect full screen

Build Details

Version: 8.0.0 Local Master
Commit:9007199254740991

Steps

Adding on in general work flow if we click on inspect button then the hit enter modal hides and only inspect show up at a time

Actual Able to view Hit Enter modal and Inspect icon modal at same time after existing inspect full screen

Expected General workflow should show there , only inspect modal should show at a time until user exit the inspect modal

Screen-Shoot image

Screen-Cast

https://user-images.githubusercontent.com/59917825/137722671-1ab660bf-21db-4009-bddc-358d134d723c.mp4

logs

elasticmachine commented 3 years ago

Pinging @elastic/security-solution (Team: SecuritySolution)

manishgupta-qasource commented 3 years ago

Reviewed & Assigned to @MadameSheema

michaelolo24 commented 3 years ago

@cchaos - This issue has presented itself in different forms for us for a while. It's tied with the overrides that @angorayc had to add here: https://github.com/elastic/kibana/pull/113419#discussion_r727397088 .

I think we would either need some type of callback to be able to close and open these popovers when the user opens / closes full screen mode. We really want to avoid another "hacky" fix here.

elasticmachine commented 3 years ago

Pinging @elastic/eui-design (EUI)

cchaos commented 3 years ago

Thanks for the ping @michaelolo24 . I've created an EUI specific issue that I'm hoping we can tackle soon https://github.com/elastic/eui/issues/5310

michaelolo24 commented 3 years ago

Closing this in favor of elastic/eui#5310

michaelolo24 commented 3 years ago

scratch that, will close this once elastic/eui#5310 is resolved

elasticmachine commented 2 years ago

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

michaelolo24 commented 2 years ago

@karanbirsingh-qasource - I think this issue may now be resolved. Can you please help us confirm in any of the current BC's? Thanks!

michaelolo24 commented 2 years ago

@karanbirsingh-qasource any updates here? Thanks!

ghost commented 1 year ago

Hi @michaelolo24

Apologies for the long delay in sharing the response, ticket got skipped from our task list.

we have tested it on the lastest BC 8.6.0 BC2 and found this issue to be still occuring ❌ .

Build Details:

Version: 8.6.0 BC2
commit:b52b34c2ff5216c395bd49c5fbc97744b646f34d
build:58485

Screen-Cast

https://user-images.githubusercontent.com/59917825/203696057-d6e6452d-83c6-4aa1-9954-c609dc09df66.mp4

MadameSheema commented 1 year ago

@michaelolo24 please take a look at the above. Thanks!