search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.66k stars 8.23k forks source link

Home plugin extension points can be mutated after start #116402

Open mshustov opened 3 years ago

mshustov commented 3 years ago

Home plugin extension points addSavedObjectsToSampleDataset and addAppLinksToSampleDataset can be called after start phase which makes the content of getSampleDatasets unpredictable in time. The plugin should be refactored to enforce strict separation between different lifecycles. This refactoring might require changes in downstream dependencies and proposing an alternative API toolset. For example, ML plugin calls addAppLinksToSampleDataset after a license check. That's incorrect since a license level can change in time, but a sample data set won't reflect these changes and might contain outdated links.

elasticmachine commented 3 years ago

Pinging @elastic/kibana-core (Team:Core)

lukeelmers commented 2 years ago

Ping @elastic/shared-ux