search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.63k stars 8.22k forks source link

[Enhancement] Consistent success and error toast should be displayed for all tabs under the Manage section #116728

Open muskangulati-qasource opened 3 years ago

muskangulati-qasource commented 3 years ago

Description: Consistent success and error toast should be displayed for all tabs under the Manage section

Build Details:

VERSION: 7.16.0-BC1
BUILD: 45504
COMMIT: 9231d806c9384df4026977ba7435a9302dc2d4ab
ARTIFACT: https://staging.elastic.co/7.16.0-255b8273/summary-7.16.0.html

Browser Details: All

Preconditions:

  1. Kibana user should be logged in.

Steps to Reproduce:

  1. Navigate to the Endpoint tab under the Manage section under Security from the left side navigation on Kibana
  2. Go to the Host Isolation Exception list tab
  3. Click on 'Add new value'
  4. In the flyout, click on the IP address field and leave it empty
  5. Observe the error message

Impacted Test case: N/A

Actual Result: Inconsistent success and error toast is displayed for all tabs under the Manage section

Expected Result: Consistent success and error toast should be displayed for all tabs under Manage section

What's working: N/A

What's not working: N/A

Screenshots:

  1. Deletion:

    • Trusted Applications Tab: DeleteOptionForTrustedApplication
    • Host Isolation Exception Tab: DeleteOptionForHostIsolationException

  2. Delete modal:

    • Trusted Applications Tab: DeleteModalForTrustedApplication
    • Host Isolation Exception Tab: DeleteModalForHostIsolationException

  3. Deletion success:

    • Trusted Applications Tab: DeleteToastForTrustedApplications
    • Host Isolation Exception Tab: DeleteToastForHostIsolationException

  4. New entry addition:

    • Trusted Applications Tab: NewValueSuccessToastForTrustedApplications
    • Host Isolation Exception Tab: NewValueSuccessToastForHostIsolationException

Logs: N/A

elasticmachine commented 3 years ago

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine commented 3 years ago

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

muskangulati-qasource commented 3 years ago

@manishgupta-qasource please review!!

manishgupta-qasource commented 3 years ago

Reviewed & assigned to @kevinlog

paul-tavares commented 3 years ago

Good catch!

cc/ @bfishel

muskangulati-qasource commented 1 year ago

Hi @kevinlog,

We have validated this ticket on the latest 8.10.0-SNAPSHOT build and found the issue is NOT FIXED. 🔴

Please find below the testing details

Build Details:

VERSION: 8.10.0
BUILD: 66009
COMMIT: f9c9722c6f568d5e730f0b2826382ca0f5508e1e

We have updated the label to the latest 8.10.0 release version .

Thanks!