Kibana Stack Monitoring links should point at local ECE instead of Elastic Cloud

elastic / kibana

Your window into the Elastic Stack

https://www.elastic.co/products/kibana

Other

19.72k stars 8.14k forks source link

Kibana Stack Monitoring links should point at local ECE instead of Elastic Cloud #118592

Open gbanasiak opened 2 years ago

gbanasiak commented 2 years ago

Kibana version: 7.15

Describe the bug:

When running in ECE Kibana Stack Monitoring incorrectly links to Elastic Cloud when no monitoring data available. This applies to both Elasticsearch Service Console and Logs and metrics. These links should point at local ECE installation, not at Elastic Cloud.

Expected behavior:

The links should point at local ECE installation based on xpack.cloud.base_url/xpack.cloud.deployment_url.

elasticmachine commented 2 years ago

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

matschaffer commented 2 years ago

Looks like that's hardcoded here https://github.com/elastic/kibana/blob/9d662b77bec867247421376ecb60a07202ed45f9/x-pack/plugins/monitoring/public/components/no_data/blurbs/cloud_deployment.js#L30

matschaffer commented 2 years ago

And seems like https://github.com/elastic/kibana/pull/95569 contains some of the existing links to that config.

matschaffer commented 2 years ago

As @jowiho mentioned in https://github.com/elastic/kibana/issues/108829 the link wording probably should be something like "Elastic Cloud Console" since it would apply to both ECE and ESS.

jasonrhodes commented 2 years ago

As @smith mentioned in our current meeting, we might be able to get this from the cloud plugin as well?