search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.67k stars 8.1k forks source link

[Stack Monitoring] Add KQL validation to Stack Monitoring alerts #119863

Open simianhacker opened 2 years ago

simianhacker commented 2 years ago

In #111663 we added KQL filters to the stack monitoring alerts. We need to add a condition that will prevent the user from saving any alerts with invalid KQL filters. We also suppressed the JSON parsing of the filterQuery in the rules like:

https://github.com/elastic/kibana/blob/75fcfe1c80ff78f2c3ef1f8065b531d171a3a273/x-pack/plugins/monitoring/server/lib/alerts/fetch_cluster_health.ts#L63-L70

After giving it some thought we should just let those errors bubble up.

Related issues and PRs:

elasticmachine commented 2 years ago

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)