search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.73k stars 8.14k forks source link

'create rollup tsvb' test causes deprecation notice #120432

Open rudolf opened 2 years ago

rudolf commented 2 years ago

Related to https://github.com/elastic/kibana/issues/120043

Running node scripts/functional_tests.js --grep 'tsvb integration' --config=x-pack/test/functional/config.js on this branch https://github.com/elastic/kibana/pull/120109

Surfaces the following deprecation notice:

ES DEPRECATION: "this request accesses system indices: [.async-search, .security-7, .tasks, .watches], but in a future major version, direct access to system indices will be prevented by default"
 Origin:user
 Stack trace:
     at processTicksAndRejections (node:internal/process/task_queues:96:5)
     at Rollup.getRollupIndexCaps (/opt/local-ssd/buildkite/builds/kb-n2-4-e697a52f8fece313/elastic/kibana-pull-request/kibana-build-xpack/node_modules/@elastic/elasticsearch/lib/api/api/rollup.js:115:16)
     at /opt/local-ssd/buildkite/builds/kb-n2-4-e697a52f8fece313/elastic/kibana-pull-request/kibana-build-xpack/x-pack/plugins/rollup/server/routes/api/indices/register_get_route.js:39:11
     at Router.handle (/opt/local-ssd/buildkite/builds/kb-n2-4-e697a52f8fece313/elastic/kibana-pull-request/kibana-build-xpack/src/core/server/http/router/router.js:163:30)
     at handler (/opt/local-ssd/buildkite/builds/kb-n2-4-e697a52f8fece313/elastic/kibana-pull-request/kibana-build-xpack/src/core/server/http/router/router.js:124:50)
     at exports.Manager.execute (/opt/local-ssd/buildkite/builds/kb-n2-4-e697a52f8fece313/elastic/kibana-pull-request/kibana-build-xpack/node_modules/@hapi/hapi/lib/toolkit.js:60:28)
     at Object.internals.handler (/opt/local-ssd/buildkite/builds/kb-n2-4-e697a52f8fece313/elastic/kibana-pull-request/kibana-build-xpack/node_modules/@hapi/hapi/lib/handler.js:46:20)
     at exports.execute (/opt/local-ssd/buildkite/builds/kb-n2-4-e697a52f8fece313/elastic/kibana-pull-request/kibana-build-xpack/node_modules/@hapi/hapi/lib/handler.js:31:20)

Which seems to come from https://github.com/elastic/kibana/blob/7.16/x-pack/plugins/rollup/server/routes/api/indices/register_get_route.ts#L27-L29

Created https://github.com/elastic/elasticsearch/issues/81345

For now this issue is just to track this deprecation warning and to ensure it's hidden in the UA from the x-elastic-product-origin: kibana header once that's enabled in Elasticsearch

elasticmachine commented 2 years ago

Pinging @elastic/kibana-stack-management (Team:Stack Management)

elasticmachine commented 5 days ago

Pinging @elastic/kibana-management (Team:Kibana Management)