search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.62k stars 8.22k forks source link

Add integration tests for security CLI utilities #121190

Open jportner opened 2 years ago

jportner commented 2 years ago

We don't have any integration tests for our CLI utilities, which can be a source of regressions when we make changes.

I don't believe we can use the regular FTS/FTR for this, we probably need to identify some other way to write integration tests.

elasticmachine commented 2 years ago

Pinging @elastic/kibana-security (Team:Security)

legrego commented 1 year ago

@elastic/kibana-operations do we have infrastructure in place to write integration tests for CLI utilities today?

mistic commented 1 year ago

I could be missing context here, but cant we use the jest integration tests setup we have to test those clits? 😃

jbudz commented 1 year ago

There's some distribution based CLI testing at https://github.com/elastic/kibana/tree/main/test/package/roles using ansible. It needs documentation though, and it's not currently available for pull requests (requires an image supporting nested virtualization that we haven't added support for spot instances on). It was added ~6 months ago to the artifacts pipeline but hasn't had much activity since. I'd probably push for a different solution but it's available if once a day testing is sufficient.