elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.63k stars 8.22k forks source link

[maps] display tooltip message when layer does not support "edit features" #124076

Open nreese opened 2 years ago

nreese commented 2 years ago

Currently, "Edit features" layer action is not displayed if the layer does not support feature editing. Instead, "Edit features" action should always be displayed but disabled (for vector layers) if the layer does not support feature editing. That way, feature editing is not hidden in the UI and users will always know why a layer can/cannot edit features.

elasticmachine commented 2 years ago

Pinging @elastic/kibana-gis (Team:Geo)

nreese commented 2 years ago

The following changes should be made to TOCEntryActionsPopover.

VectorLayer and VectorSource supportsFeatureEditing method should be updated to return Promise<boolean, editFeaturesDisabledReason>. Implementations of supportsFeatureEditing should provide user understandable reasons why feature editing is not supported (which configurations or constraints do not allow for feature editing).

elasticmachine commented 2 years ago

Pinging @elastic/kibana-presentation (Team:Presentation)