search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.76k stars 8.15k forks source link

[Security Solution] Use search strategy `showError` instead of `addError` #125263

Open stephmilovic opened 2 years ago

stephmilovic commented 2 years ago

In security solution, we have our own error toaster component addError. When we made the switch from GraphQL to Search Strategy, we were unaware of the Search Strategy data.search.showError method and continued using addError. The showError includes special error handling for specific cases. For example, take a look at the same error passed to addError, and then passed to showError: before better

We should replace every addError handling an error for search strategy (data.search.search) with the data.search.showError method.

I have already made the change in timeline, which is the gifs above: https://github.com/elastic/kibana/pull/125178

elasticmachine commented 2 years ago

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

elasticmachine commented 2 years ago

Pinging @elastic/security-solution (Team: SecuritySolution)