[Reporting] Remove `hide-for-sharing` CSS utility

elastic / kibana

Your window into the Elastic Stack

https://www.elastic.co/products/kibana

Other

19.61k stars 8.22k forks source link

[Reporting] Remove `hide-for-sharing` CSS utility #126670

Open jloleysens opened 2 years ago

jloleysens commented 2 years ago

Currently, reporting injects a CSS utility that applies "display: none" to targeted elements. Given that we now have a screenshotMode plugin we should be able to drive this entirely from JS, with individual plugins managing which elements are hidden.

Additional notes

this is currently only used by preserve-layout screenshots.
related PR https://github.com/elastic/kibana/pull/126475

elasticmachine commented 2 years ago

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

elasticmachine commented 2 years ago

Pinging @elastic/kibana-app-services (Team:AppServicesUx)