search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.68k stars 8.23k forks source link

[Inspector] Use tabs for view selection #126918

Open MichaelMarcialis opened 2 years ago

MichaelMarcialis commented 2 years ago

The current view selection interface for Lens' inspect flyout is currently less-than-ideal. The view selection currently uses a combination of a button and subsequent popover. Interacting with this requires two clicks from a user in order to switch views, even though the popover only contains two options. Additionally, the placement of the button doesn’t look great, with the button being in such close proximity to the offset close flyout button.

I’d like to suggest that we change the button/popover to instead be a set of tabs that appear below the “Inspector” heading. This will better expose the view options to users, allow them to quickly change with a single click, and also likely look better.

image

CCing @andrewctate, as he was the one that kindly brought this to my attention.

elasticmachine commented 2 years ago

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

elasticmachine commented 2 years ago

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

flash1293 commented 2 years ago

This UI is shared across all of Kibana and owned by app services, I'll relabel.

I agree with the sentiment, it would be nice to have a dead simple switch for the views because there are often just 2 or 3 (for more than that it could fall back to the dropdown)

elasticmachine commented 10 months ago

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

elasticmachine commented 10 months ago

Pinging @elastic/kibana-visualizations (Team:Visualizations)

elasticmachine commented 10 months ago

Pinging @elastic/kibana-presentation (Team:Presentation)

stratoula commented 10 months ago

Correct me if I am wrong but this is a request for the entire inspector, no? We can't have different UI in Lens and different in Discover.

With that being said and as the UI is owned by the presentation team I will also ping them in the issue.

ThomThomson commented 10 months ago

Removing the Data discovery team and the Visualizations team from this issue as Presentation team owns the inspector plugin. Will keep this one open for the time being as it seems fairly small.

MichaelMarcialis commented 10 months ago

Correct if I am wrong but this is a request for the entire inspector, no? We can't have different UI in Lens and different in Discover.

With that being said and as the UI is owned by the presentation team I will also ping them in the issue.

Thanks, @stratoula. Correct, this is not a Lens-specific issue. This is the inspector in general. I believe this concern will be addressed as part of the work that @nreese will be doing to implement my designs for enhancements to the remote clusters experience.