Test `is superseded by migration errors and does not run if a migration fails` is dependent on branch version

[mistic]

I think we should try to rewrite the test is superseded by migration errors and does not run if a migration fails at src/core/server/saved_objects/validation/integration_tests/validator.test.ts to not be dependent on the version of the branch otherwise it implies this file needs to be changed at each version bump.

[elasticmachine]

Pinging @elastic/kibana-core (Team:Core)

[pgayvallet]

We're using the kibana version in the declarations

https://github.com/elastic/kibana/blob/b7e366c483016f63b1b1d0598adff2c7037e3dc3/src/core/server/saved_objects/validation/integration_tests/validator.test.ts#L109-L113

but not in the snapshot:

https://github.com/elastic/kibana/blob/b7e366c483016f63b1b1d0598adff2c7037e3dc3/src/core/server/saved_objects/validation/integration_tests/validator.test.ts#L193-L195

We need to replace the snapshot-based assertion with something using the actual version number (or use string interpolation in the snapshot, but that's kinda bad when running with -u)

[afharo]

Probably just matching the error message to a text instead of a snapshot?

}).rejects.toThrowError(`Migration function for version ${version} threw an error`); 

[pgayvallet]

Yup, that was

or use string interpolation in the snapshot, but that's kinda bad when running with -u

It's fine, the issue is that any snapshot update will override the custom string. But we can just be careful about that.