elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.73k stars 8.14k forks source link

(Accessibility) Ensures all ARIA attributes have valid values on search sessions table when user toggles on a single status #128009

Open bhavyarm opened 2 years ago

bhavyarm commented 2 years ago

Found while writing a11y tests for https://github.com/elastic/kibana/pull/128005 I tried to filter the search sessions management table on a single status:

it('Search sessions management toggled on a single status meets a11y requirements ', async () => {
        await (await find.byCssSelector('[title="expired"]')).click();

        await retry.try(async () => {
          await a11y.testAppSnapshot();
        });
       await testSubjects.click('clearSearchButton');
    });

And the test fails with a11y validation error . Adding retry or sleep doesn't work.

search sessions a11y tests
       Search sessions management toggled on a single status meets a11y requirements :

      retry.try timeout: Error: a11y report:

 VIOLATION
   [aria-valid-attr-value]: Ensures all ARIA attributes have valid values
     Impact: critical
     Help: https://dequeuniversity.com/rules/axe/4.0/aria-valid-attr-value?application=axeAPI
     Elements:
       - <ul id="i2bde3041-a632-11ec-9295-fd16ce5a4e65" role="listbox" tabindex="0" aria-multiselectable="true" aria-label="Status" aria-activedescendant="i2bde3041-a632-11ec-9295-fd16ce5a4e65_option--1">
     at AccessibilityService.assertValidAxeReport (/Users/bhavyarajumandya/Desktop/kibana_dev/kibana/test/accessibility/services/a11y/a11y.ts:76:13)
     at AccessibilityService.testAppSnapshot (/Users/bhavyarajumandya/Desktop/kibana_dev/kibana/test/accessibility/services/a11y/a11y.ts:49:10)
     at runMicrotasks (<anonymous>)
     at processTicksAndRejections (node:internal/process/task_queues:96:5)
     at /Users/bhavyarajumandya/Desktop/kibana_dev/kibana/x-pack/test/accessibility/apps/search_sessions.ts:43:11
     at runAttempt (/Users/bhavyarajumandya/Desktop/kibana_dev/kibana/test/common/services/retry/retry_for_success.ts:29:15)
     at retryForSuccess (/Users/bhavyarajumandya/Desktop/kibana_dev/kibana/test/common/services/retry/retry_for_success.ts:68:21)
     at RetryService.try (/Users/bhavyarajumandya/Desktop/kibana_dev/kibana/test/common/services/retry/retry.ts:31:12)
     at Context.<anonymous> (/Users/bhavyarajumandya/Desktop/kibana_dev/kibana/x-pack/test/accessibility/apps/search_sessions.ts:42:9)
     at Object.apply (/Users/bhavyarajumandya/Desktop/kibana_dev/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
   Error: retry.try timeout: Error: a11y report:
elasticmachine commented 2 years ago

Pinging @elastic/kibana-accessibility (Project:Accessibility)

elasticmachine commented 2 years ago

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

1Copenut commented 2 years ago

Pinging @1Copenut for visibility

elasticmachine commented 1 year ago

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)