elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.76k stars 8.16k forks source link

[Enhancement]: On clicking the `view enrolled agent` button no agents are filtered under Agents tab. #130101

Open ghost opened 2 years ago

ghost commented 2 years ago

Description: Currently on this button as per our understanding we would like to proposed below mentioned changes.

Enhancement 1: On hovering over the view enrolled agent button no tooltip is displayed as the button is a link and redirecting users to agent list page. So a tooltip should be provided on the mentioned button. For your reference we have provided recording below:

https://user-images.githubusercontent.com/102019374/163192639-899a4d84-52fd-4e1f-a2f3-76705c6ba601.mp4

Enhancement 2: Query

  1. Could you please confirm if it is expected to display complete list of agents available on agent tab when clicked on view enrolled agent button? However, as per our understanding the agent count showed during enrollment on flyout should only be visible when navigated to agent tab. For example, when user clicked the view enrolled agent button user should be navigated to agent tab with filtered results considering the agent policy we used during enrollment.

Screenshot: Screenshot (359) Screenshot (361)

Steps to reproduce:

  1. Login to Kibana environment.
  2. Navigate to Integration tab.
  3. Select system integration.
  4. Go to Integration policies under system integration.
  5. Then, click on add agent button from actions menu.
  6. Click on view enrolled agent button.
  7. Observe that on clicking the view enrolled agent button no tooltip is displayed and the agent policy is not filtered.

Build details:


VERSION: 8.2.0-SNAPSHOT
BUILD: 51882
COMMIT: 57e5dd6012953e70c822d4dd8d04a6ab9ff3ab6d
elasticmachine commented 2 years ago

Pinging @elastic/fleet (Team:Fleet)

ghost commented 2 years ago

@manishgupta-qasource Please review.

manishgupta-qasource commented 2 years ago

Secondary review for this ticket is Done

jen-huang commented 2 years ago

@criamico Can you confirm the expected behavior of this button?

criamico commented 2 years ago

Currently this is a link button that takes the user to the list of agents and there's no filtering applied on it. I looked in the design document and the other tickets and there is no detail about that specific button. There was some discussion about adding the filtering on the button in the "incoming data" component but because of time constraints it had to be cut. I think that we can have an enhancement ticket where this gets addressed.

kpollich commented 1 year ago

@criamico - If you're able to refresh your memory here could you point me to an enhancement issue or chime in on whether this is still relevant? Thanks!

criamico commented 1 year ago

@kpollich We don't have an enhancement issue for this ticket.

Maybe @nimarezainia or @dborodyansky are able to chime in on this: Should we show a filtered list of agents when clicking on "view enrolled agents" in the agent enrollment flyout or is it ok to keep showing the entire list?

dborodyansky commented 1 year ago

Is it likely that the newly enrolled agent(s) would be displayed at the top of the unfiltered table? I think showing entire list is appropriate, but if we can promote the new ones to the top it would be ideal.

harshitgupta-qasource commented 1 year ago

Hi Team,

We have revalidated this issue on latest 8.10.0 SNAPSHOT kibana cloud environment and found it still reproducible.

Observations:

ScreenCast:

https://github.com/elastic/kibana/assets/101545338/a7ec9217-1970-43e0-8a03-0ab438a08118

Build details: VERSION: 8.10.0 SNAPSHOT BUILD: 65561 COMMIT: 4dadcbb91136a3e7d39e4b419aa12e21a37e4918

Please let us know if anything else is required from our end.

Thanks!