search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.64k stars 8.23k forks source link

Lens displays heatmap instead of region map because data is not loaded #130674

Open bhavyarm opened 2 years ago

bhavyarm commented 2 years ago

Kibana version: 8.2.0 BC3

Elasticsearch version: 8.2.0 BC3

Server OS version: darwin_x86_64

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: Lens app displays heatmap instead of region map when user tries to create region map first because data is not loaded.

https://user-images.githubusercontent.com/7074629/164250021-dc761813-2d0d-4f11-8419-f440279d8568.mp4

elasticmachine commented 2 years ago

Pinging @elastic/kibana-gis (Team:Geo)

bhavyarm commented 2 years ago

cc @flash1293

flash1293 commented 2 years ago

@nreese The problem here is that the region map visualization is not returning a suggestion if there is no active data yet even if it's the active visualization already (if state is defined it shouldn't bail out here): https://github.com/elastic/kibana/blob/3730dd0779ed8efd74aee88f57422781ec1ac122/x-pack/plugins/maps/public/lens/choropleth_chart/suggestions.ts#L25

To add handling for this case, add a visualization which tries to use the table being passed in on a best effort basis even if there's no data to check for the right shape map. Maybe it can leave the shape mapping empty and then pick it on the fly as part of the renderer (and show an error message if it doesn't find one)?

elasticmachine commented 2 years ago

Pinging @elastic/kibana-presentation (Team:Presentation)