elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.6k stars 8.21k forks source link

[ResponseOps] consider making some plugin config available in the UX via Advanced Settings #132183

Open pmuellr opened 2 years ago

pmuellr commented 2 years ago

The alerting, actions, and task_manager plugins have a lot of configuration options:

config code from the plugins https://github.com/elastic/kibana/blob/c93afa02884af7bba4da2391f7725e9d9afe5785/x-pack/plugins/alerting/server/config.ts#L12-L64 https://github.com/elastic/kibana/blob/c93afa02884af7bba4da2391f7725e9d9afe5785/x-pack/plugins/actions/server/config.ts#L19-L120 https://github.com/elastic/kibana/blob/c93afa02884af7bba4da2391f7725e9d9afe5785/x-pack/plugins/task_manager/server/config.ts#L24-L146

During a retrospective, it was noted that keeping all the meta-data around the config up-to-date is a chore. We have keys that are allowed to be used as env vars in Docker in one file, an allow-list for cloud usage in another file in another repo, and asciidoc documentation in several places, some duplicated between cloud and Kibana docs.

One thought was to try to move some of this configuration so that it could be edited "live", via Advanced Settings (AS).

pros:

cons:

I think we'd need to do the following:

elasticmachine commented 2 years ago

Pinging @elastic/response-ops (Team:ResponseOps)

mikecote commented 2 years ago

Linking with https://github.com/elastic/kibana/issues/137303.

pmuellr commented 1 year ago

One thing I didn't realize when originally creating this issue, is that Advanced Settings / uiSettings only supports space-specific settings. So, this became a non-starter.

Since then, support for global settings has been added; here's one of the referenced PRs around it: https://github.com/elastic/kibana/pull/147229. So, seems do-able again ...

pmuellr commented 1 year ago

It's been a while since we looked / thought about this one, so I'm going to set it up for triage again, especially since now it might be possible to implement (where it wasn't before, with space-specific advanced settings).