Address cross-boundary import violations in Deployment Management UIs

cjcenizal commented 2 years ago

See https://github.com/elastic/kibana/pull/136911 for context.

[ ] src/plugins/es_ui_shared/__packages_do_not_import__/authorization/components/authorization_provider.tsx
[ ] src/plugins/es_ui_shared/__packages_do_not_import__/authorization/components/page_error.tsx
[ ] x-pack/plugins/license_api_guard/server/shared_imports.ts

elasticmachine commented 2 years ago

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

spalger commented 2 years ago

Thanks for creating this issue @cjcenizal, In this case of the first two violations the issue is that the __packages_do_not_import__ code is outside of a server, public, or common dir, so it's not feasible to determine the intended destination for that code.

By default that code is categorized as "common" because it lives outside those directories, but if we could maybe create a __packages_do_not_import__ dir inside the server dir for the server-specific pieces that would resolve the first two issues.

Let me know if you need help with the third violation but it seems like a pretty standard case of mocks being included where they shouldn't be.

elasticmachine commented 4 days ago

Pinging @elastic/kibana-management (Team:Kibana Management)

elastic / kibana

Address cross-boundary import violations in Deployment Management UIs #137529