search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.63k stars 8.22k forks source link

Log Threshold UX errors with missing filter values not obvious enough to notice #137630

Open pmuellr opened 2 years ago

pmuellr commented 2 years ago

Kibana version: 8.3.2

Describe the bug:

One of the UX validation errors that can occur when a user is creating a log threshold alerting rule is that they enter a field to filter log documents on, but not the actual value. When in this state, the UX appears as follows:

image

You can click on the red IS (or maybe WITH {{field}} text), to get a prompter to provide a value, which will clear the validation error so the rule can then be saved.

However, that red IS is barely noticeable. A user who reported this to me thought there was a more general bug that they couldn't save rules - in this case, they couldn't save because of the validation error, but they had no idea there was actually a validation error.

Steps to reproduce:

  1. Start creating a log threshold alerting rule, either from the Observability pages or Stack Management pages
  2. Fill in all the required fields EXCEPT for the filter value (enter a filter field though) in the WITH section
  3. You should see the red IS

Expected behavior:

An obvious error message indicating the filter value needs to be provided.

elasticmachine commented 2 years ago

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

elasticmachine commented 2 years ago

Pinging @elastic/actionable-observability (Team: Actionable Observability)

elasticmachine commented 2 years ago

Pinging @elastic/response-ops (Team:ResponseOps)

kdelemme commented 1 year ago

@maciejforcone We will need your input on UX

kdelemme commented 1 year ago

@maciejforcone Do you think there is a better UI that we could implement there to surface the error?

fkanout commented 1 year ago

The IS component is part of the EUI lib, so it would be on the Platform backlog.