search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.69k stars 8.24k forks source link

Refactor alerting task runner - remove RecoveryActionGroupId #139208

Open doakalexi opened 2 years ago

doakalexi commented 2 years ago

Meta issue: https://github.com/elastic/kibana/issues/124206

While Ersin was working on the alerts summary POC he realized that having a separate RecoveryActionGroupId is making refactoring hard. It is forcing us to do tons of type conversion tricks. Can't we get rid of it? it's just another ActionGroupId, why do we separate it?

mikecote commented 1 year ago

I found a place using a custom recovery action group. It's within the geo threshold rule type => https://github.com/elastic/kibana/blob/main/x-pack/plugins/stack_alerts/server/rule_types/geo_containment/alert_type.ts#L233-L238 so we'll have to keep that in mind if we remove it.