search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.71k stars 8.13k forks source link

[Lens] New computed suggestion title is temporary set for old preview while computing #139456

Closed dej611 closed 7 months ago

dej611 commented 2 years ago

While computing newer suggestions in the editor, the new title is matched with the old preview while computing, which is a bit confusing if the computation takes a bit longer than few ms.

loading_charts

Perhaps a different feedback can be provided to the user while refreshing/computing. Here's few ideas, but feel free to suggest more:

cc @MichaelMarcialis

elasticmachine commented 2 years ago

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

MichaelMarcialis commented 2 years ago

I like the idea of giving it a skeleton screen type treatment, with an empty gray box being used to represent the yet-to-be-rendered visualization within the panel. If we wanted to give it some extra polish, it would be cool if we could also apply the same CSS gradient animation that is used on the EuiLoadingContent component (see EUI docs). You might even be able to get rid of the EuiProgress components on the suggestion panels with that animation in place (for a more subtle, less distracting approach).

If that's a direction ya'll would like to pursue, let me know if that description is enough to go by, or if ya'll need a quick mockup.

flash1293 commented 2 years ago

So to summarize, the idea is to not show the old vis if the suggestion changes the name / chart type but instead show a chart placeholder, but still keep the current behavior for cases where the chart only changes filters/time range, right?

dej611 commented 2 years ago

@flash1293 yes, I think that makes sense. The suggestion system should be able to detect the difference, right?

stratoula commented 7 months ago

Closing this as we removed the preview from the suggestions