elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.67k stars 8.23k forks source link

[ML] Replace legacy SCSS overwrites with css-in-js #140695

Open darnautov opened 2 years ago

darnautov commented 2 years ago

We have 91 scss files, some of them contain potentially dangerous EUI overwrites. As EUI delivers the css-in-js support with emotion, we should migrate these custom styles for both EUI components and regular HTML elements (using css helper from @emotion/react), utilizing appropriate theme variables from useEuiTheme hook.

Besides that, alongside the updated classes, all inline styles should be replaced with css.

Would be better to split this task by page, potentially we can break it down even further, especially the components folder.

elasticmachine commented 2 years ago

Pinging @elastic/ml-ui (:ml)