elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.71k stars 8.13k forks source link

[Security Solution]No tags Available text can be shown under Tag edition of cases #145214

Closed ghost closed 1 year ago

ghost commented 1 year ago

Describe the bug No tags Available text can be shown under Tag edition of cases

Build Details:

Version:8.6.0-SNAPSHOT
Commit:2e04dac8367f95a986ed0ee32fd030bb3f6d5d0f
Build:58242

Steps

Whats working

image

Screen-Cast:

https://user-images.githubusercontent.com/59917825/201875183-0ce0a929-5802-456f-922f-013ae259f6f7.mp4

elasticmachine commented 1 year ago

Pinging @elastic/security-solution (Team: SecuritySolution)

ghost commented 1 year ago

@deepikakeshav-qasource please review

elasticmachine commented 1 year ago

Pinging @elastic/response-ops (Team:ResponseOps)

elasticmachine commented 1 year ago

Pinging @elastic/response-ops-cases (Feature:Cases)

cnasikas commented 1 year ago

Thanks for the suggestion! The use case here is different from the rules. I think it is self-explanatory that they are not results. @mdefazio what do you think?

mdefazio commented 1 year ago

Thanks for this! I think this might be a nice addition so its clearer that the user is adding a tag and not selecting a current one by accident. Let me mock up the position as I'm not certain what the hierarchy should be off the top of my head.

mdefazio commented 1 year ago

Tried placing the text above and below, but think below is better. Do we think this is clearer?

Prefer the 'No tags match your search' here rather than 'No tags available'.

image

cnasikas commented 1 year ago

LGMT!