search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.82k stars 8.21k forks source link

[Cloud Posture] simplify agent deployment instructions #145549

Open orouz opened 1 year ago

orouz commented 1 year ago

Describe the feature:

we'd like to make it as simple as possible to add an agent with a cloud_security_posture package. currently there's multiple tabs with deployment instructions, but only k8s is relevant for us. to that end, when users who have our integration installed continue to add an agent, we select the k8s tab for them:

Screen Shot 2022-11-17 at 12 48 51

this happens here: https://github.com/elastic/kibana/blob/453cdf96bfe4f398e972b821a6d1fc9c493d0ab0/x-pack/plugins/fleet/public/components/platform_selector.tsx#L66

because we added our package here: https://github.com/elastic/kibana/blob/453cdf96bfe4f398e972b821a6d1fc9c493d0ab0/x-pack/plugins/fleet/public/components/agent_enrollment_flyout/hooks.tsx#L17

what we'd like to do is the remove/disable all other tabs and show just the kubernetes tab.

but we need to consider that an agent policy might have more packages except our own. in which case, disabling the tabs may not be fitting.

cc @tinnytintin10 @oren-zohar @tehilashn @kfirpeled

elasticmachine commented 1 year ago

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security Posture)

orouz commented 1 year ago

as an example, a user had an issue where they tried to deploy an agent on windows and got the following error: 

The system cannot find the file specified.\n\t* call to 'https://artifacts.elastic.co/downloads/cloudbeat/cloudbeat-8.5.0-windows-x86_64.zip' returned unsuccessful status code: 404\n\n

as cloudbeat isn't supported in that environment.

tinnytintin10 commented 1 year ago

@orouz thank you for creating this!

As far as I am aware, we've developed and tested our integration to work when elastic-agent is deployed as DaemonSet in k8s cluster. With this in mind, I support removing the other none k8s deployment options.

When it comes to CIS AWS (CSPM), we should hide the k8s and MacOS options.

@kfirpeled should I create an issue to track these requirements separately or are y'all okay to continue tracking them as quick wins?

kfirpeled commented 1 year ago

We can fix that once https://github.com/elastic/kibana/issues/151701 will be fixed