search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.65k stars 8.23k forks source link

Data views - date field's "set format" toggle does not save state #146059

Open erekalper opened 1 year ago

erekalper commented 1 year ago

Kibana version: 8.4.0

Elasticsearch version: 8.4.0

Browser version: Google Chrome Version 107.0.5304.107

Browser OS version: Windows 10, Windows 11

Describe the bug: When working in Stack Management -> Data Views, specifically on views with date fields, the toggle switch for Set format does not save state. That is, if it's turned on from an off state, saved, and then reloaded, it still shows as off. Same when it's turned off from an on state.

Steps to reproduce:

  1. Navigate to Stack Management.
  2. Navigate to Data Views.
  3. Select a data view that has a date field.
  4. Click the edit icon for that field specifically.
  5. Toggle the Set format switch to either on or off.
  6. Click Save.
  7. Reload the page.
  8. Again click the edit icon for that field specifically.
  9. The toggle switch will be where it was pre-save.

Expected behavior: We expect the state of the toggle switch to be saved (along with any custom formatting that may have been applied).

Screenshots (if relevant): I can post screenshots if desired, though they would simply show the toggle as off (or on).

elasticmachine commented 1 year ago

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

mattkime commented 1 year ago

If no format is selected, then the format section will be closed when displayed again. There's no meaningful difference between the format section disable and the format section enabled without a formatter selected.

elasticmachine commented 1 year ago

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

erekalper commented 1 year ago

Sorry for the delayed reply, but I definitely should've noted that this has been happening even when a format is selected. I'll double check everything again and aim to post some screenshots later tonight or tomorrow. Thank you for your response!

kertal commented 1 year ago

Hi @erekalper , did you manage to double check? Many thx!

mattkime commented 1 year ago

This may be related - https://github.com/elastic/kibana/pull/148497